How to help project?

Oct 5, 2011 at 2:03 PM

Hello,

I like the project and I would like to share minor bugfixes and improvements. But I've never done distributed development. Please tell me how I can cooperate.

At the moment I can suggest a patch to solve empty search issue and to throw exception when mailbox cannot be selected.

diff -r 566024417d4a ImapClient.cs
--- a/ImapClient.cs    Tue Sep 27 14:24:20 2011 -0500
+++ b/ImapClient.cs    Wed Oct 05 17:52:07 2011 +0400
@@ -553,11 +553,11 @@
                 string[] uids = m.Groups[1].ToString().Trim().Split(' ');
                 foreach (string s in uids) {
                     ms.Add(s);
-                }
-                return ms.ToArray();
-            } else {
+                }               
+            } else if (!response.StartsWith("* SEARCH",StringComparison.InvariantCultureIgnoreCase)) {
                 throw new Exception(response);
             }
+            return ms.ToArray();
         }
 
         public Mailbox SelectMailbox(string mailbox) {
@@ -585,6 +585,8 @@
                     if (response.ToUpper().IndexOf("READ/WRITE") > -1) x.Rw = true;
                 }
                 _selectedmailbox = mailbox;
+            } else {
+                throw new Exception(response);
             }
             IdleResume();
             return x;

Coordinator
Oct 24, 2011 at 5:42 PM

This should be resolved in the latest checkin.