This project is read-only.
2

Closed

ImapClient.cs: minor issues with tagged OK responses in SELECT and EXAMINE commands

description

Hi there.
I was checking out your library (pretty good btw) and saw that the SELECT command always ends up not setting Mailbox.Rw to true when the server answers with an OK [READ-WRITE].
That's because the code in the Select method of file ImapClient.cs checks for the existence of "READ/WRITE" instead of "READ-WRITE" (as stated in RFC 3501, section 6.3.1).
Nothing major, but it could fool someone using the library.
As an aside, section 6.3.2 of the same RFC (EXAMINE command) states that the tagged OK response must begin with [READ-ONLY], so the code in the Examine method that checks for the existence of "READ/WRITE" seems unnecessary.
Keep up the good work.

comments

andyedinborough wrote Oct 24, 2011 at 6:20 PM

Sorry for the INCREDIBLY LONG delay in responding. I hate how Codeplex doesn't notify you of new issues/discussions automatically. The code in question here was inherited from another project. I've made the changes you've specified (http://aenetmail.codeplex.com/SourceControl/changeset/changes/1aef3b09c7e2). Thanks!

ssarabando wrote Oct 26, 2011 at 10:27 AM

No problem. And I see the project is now also in github. Good. :)